Skip to content

Conversation

@tcheronneau
Copy link
Contributor

@tcheronneau tcheronneau commented Jan 10, 2026

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jan 10, 2026
@tcheronneau tcheronneau force-pushed the nixos/qui branch 3 times, most recently from c29bde6 to 6d55f8c Compare January 11, 2026 14:56
@tcheronneau tcheronneau requested a review from stepbrobd January 11, 2026 15:10
@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Jan 11, 2026
@undefined-landmark
Copy link
Contributor

Hi, good work! I created a PR sometime before yours that is basically ready to merge: #472934. Please take a look and let me know if I missed anything that is present in yours.

@tcheronneau
Copy link
Contributor Author

Hi, good work! I created a PR sometime before yours that is basically ready to merge: #472934. Please take a look and let me know if I missed anything that is present in yours.

Indeed did not saw it before making mine.
But it looks good to me.

@undefined-landmark
Copy link
Contributor

No worries. I'll send a message in matrix to try to get it merged.

@undefined-landmark
Copy link
Contributor

Closing this PR since #472934 got merged. Feel free to ping me if you'd like to change something about the module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants